Prevent abuse case, fix desynch bug, prevent unintentional adding of non-scene participants via web portal #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…portal unless you specifically tell it to. This solves the following webportal texting issue: Assuming the last person you texted was A: 1) Send a text in scene 1 (members: you, A) without specifying the recipient. - Result: Your message is sent to A (the other participant in your scene). 2) Switch to scene 2 in the play menu (members: you, B) and send a text without specifying the recipient - Result: Your message is sent to A (not a member of the scene) and A is added to the scene. With this change, the second case will instead return an error message to the web portal and require that you explicitly add them to the scene with `name[ name...]=message`.
|
Appreciate the contribution. It's up to the original authors (Tat/skew) to decide whether to accept the change, though. I would suggest contacting them on the Ares discord or forums. |
Fixed a bug that could cause desynchronization between client and webportal last-texted states.
Ell-Ares
changed the title
…t here- if the check succeeds, it returns immediately, so there is no case where the check succeeds and subsequent code is executed.
Now includes a helpful hint: > Headwiz isn't in this scene yet. Please use `Headwiz tester=message` if you want them added.
…pport it, use the shortcut command instead).
|
Similar functionality has been implemented by Tat, so this PR is no longer needed. |
|
I've made a number of changes to how texting works, including the default assumption on the webportal. I added in a check for unapproved characters on text/send and text/newscene - thanks for the catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevented unapproved characters from sending text messages.
Previously there were no checks to see if characters were approved before texting, which enabled the txt plugin to be abused to spam characters ICly. This is no longer possible.
Fixed a bug that caused de-synchronization between client and web portal last-texted states in certain scenarios.
This solves the following web portal texting issue:
txt Alice/122=messagetxt/newscene Brandon=message(scene 123 is created)helloPrevented unintentional addition of non-scene participants to scene via web portal text messages.
This solves the following web portal texting issue:
Assuming the last person you texted was A:
With this change, the second case will instead return an error message to the web portal and require that you explicitly make them a member of the scene first. It recommends that you add them to the scene with
name[ name...]=messageto send the message seamlessly, but any method of including them will work.