Move common.py to ./<repo-root>/arelle from arelle/plugin/validate/ESEF, and rename to typing.py #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
ggravlingen
force-pushed
the
move-common-to-plugin
branch
from
715967d to
91bb8dd
Compare
ggravlingen
changed the title
ggravlingen
changed the title
sagesmith-wf
approved these changes
Aug 22, 2022
austinmatherne-wk
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
We are going to need the contents of this file when continuing the work of adding type hints to the other validation plugins. It looks like this and possibly other functions are being reused so they could be moved to
typing.pyas well.Description of change
common.pyhas been moved fromarelle/plugin/validate/ESEFtoarelle/and renamed totyping.py.Steps to Test
review:
@Arelle/arelle