Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Camera: image-start-capture with all zeros leads to infinite pics at zero interval #25073

Closed
rmackay9 opened this issue Sep 22, 2023 · 1 comment · Fixed by #25075
Closed
Labels

Comments

@rmackay9
Copy link
Contributor

PR #24772 added support for the IMAGE_START_CAPTURE command's (time) Interval and Total Images fields.

While it interprets the command correctly, if all fields are left as zero the result is:

CameraId:0 = all cameras
Interval=0 (as quick as possible)
TotalImages=0 (capture forever)

So the camera library will take tons of images very quickly and also send tons of notifications to the GCS.

While it may not be exactly according to the mavlink spec I think we should interpret an all zero command as wanting to take just a single picture on all cameras immediately.

@rmackay9 rmackay9 added the BUG label Sep 22, 2023
@rmackay9
Copy link
Contributor Author

This branch should resolve this issue I think https://github.com/rmackay9/rmackay9-ardupilot/commits/camera-multipic-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant