Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Workflow #2233

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Fix for Workflow #2233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a42d891
change gradle
Kaiserdragon2 Aug 3, 2024
2c46730
fix Workflow to accept signing Config
Kaiserdragon2 Aug 3, 2024
161babb
Signing config
Kaiserdragon2 Aug 3, 2024
142a6e1
Misssing "
Kaiserdragon2 Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/BuildDebug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
java-version: 21
cache: gradle
- name: Write sign info
if: github.repository_owner == 'Donnnno'
run: |
echo "Workflow manually triggered by ${{ github.actor }}"
if [ ! -z "${{ secrets.KEYSTORE }}" ]; then
echo storePassword='${{ secrets.KEYSTORE_PASSWORD }}' >> keystore.properties
echo keyAlias='${{ secrets.KEY_ALIAS }}' >> keystore.properties
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/BuildRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ jobs:
java-version: 21
cache: gradle
- name: Write sign info
if: github.repository_owner == 'Donnnno'
run: |
if [ ! -z "${{ secrets.KEYSTORE }}" ]; then
echo "Workflow manually triggered by ${{ github.actor }}"
if [ ! -z "${{ secrets.KEYSTORE }}" ]; then
echo storePassword='${{ secrets.KEYSTORE_PASSWORD }}' >> keystore.properties
echo keyAlias='${{ secrets.KEY_ALIAS }}' >> keystore.properties
echo keyPassword='${{ secrets.KEY_PASSWORD }}' >> keystore.properties
Expand Down
4 changes: 2 additions & 2 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ android {
signingConfig.setStoreFile(rootProject.file(keystoreProperties.getProperty("storeFile")));
signingConfig.setStorePassword(keystoreProperties.getProperty("storePassword"));
});
} else {releaseSigning = signingConfigs.named("debug"); // Use getByName for safety
}
} else {releaseSigning = signingConfigs.getByName("debug"); // Use getByName for safety
}

buildFeatures {
buildConfig = true
Expand Down