Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #468.
I remembered to:
develop
and set to merge intodevelop
I ran tests by doing
pip install . -t thematrix/ --no-dependencies
followed bycd thematrix/ && nosetests --with-coverage --cover-package=wpull --cover-branches
, but that didn't seem to actually runrequest_test.py
(in that I didn't see any relevant error output if I changed the test but not the rest of the code). I also didpython3 -m unittest wpull.protocol.http.request_test
which did fail before my change and now passes.Unfortunately, it seems like cloudflare doesn't hate me, so I'm not able to tell if this actually fixes anything in practice.