Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked CSS URL regex to deal with empty url() properties and long data URIs #382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DoomTay
Copy link

@DoomTay DoomTay commented Dec 20, 2017

This pull request fixes #374 along with long data URIs containing parenthesis being misparsed, like here

I remembered to:

  • Update or add unit tests if needed
  • Update or add documentation/comments if needed
  • Made sure stray files or whitespace didn't get committed
  • Read the guidelines for contributing

Changes:

  • Replaced {1,500} with an asterisk. This helps account for empty url() paths as well as longer data URIs that happen to have parentheses in them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant