Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: rework python version check #4294

Merged

Conversation

black-sliver
Copy link
Member

@black-sliver black-sliver commented Nov 30, 2024

What is this fixing or adding?

  • Makes version check for official distribution and docs match
  • Add warning for 3.10.11 having known security issues
  • Relaxes the check for micro updates on platforms that may not use the official distribution/versioning
  • Sets min python version for build and release to current latest (with known security fixes)

How was this tested?

  • On Linux, Launcher fails on py3.9.x, but works on 3.10.14 (updating to 3.10.15 now)
  • CI would probably fail if I got the versions wrong
  • Seeing UserWarning: Python Version sys.version_info(major=3, minor=10, micro=11, releaselevel='final', serial=0) has security issues. Don't use in production. in CI

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 30, 2024
@black-sliver
Copy link
Member Author

black-sliver commented Nov 30, 2024

Hm, 3.10.15 is listed here: https://github.com/actions/python-versions/blob/main/versions-manifest.json#L3577

Oh - it does not have a Windows release.

@black-sliver black-sliver marked this pull request as draft November 30, 2024 02:32
@black-sliver black-sliver marked this pull request as ready for review November 30, 2024 12:23
@black-sliver black-sliver merged commit b83b486 into ArchipelagoMW:main Nov 30, 2024
21 checks passed
@black-sliver black-sliver deleted the fix/moduleupdater-version branch November 30, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants