Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUNIC: Make the shop checks require a sword #3620

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

ScipioWright
Copy link
Collaborator

What is this fixing or adding?

There has been enough feedback about this that it's about time to add it, especially since people keep doing single player ladder shuffle.

Normally I would add the rule to the entrance, but for the er_rules, there are either 1 or 6 (default 6) entrances that lead to the shop, so it's probably better to just add the rule directly to the location.

How was this tested?

Ran gen

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 4, 2024
@ScipioWright ScipioWright added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jul 4, 2024
Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed using plando that gen fails when the swords are in the shop (and that it used to pass, before this PR).

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 5, 2024
@NewSoupVi NewSoupVi merged commit d4d0a3e into ArchipelagoMW:main Jul 5, 2024
17 checks passed
@ScipioWright ScipioWright deleted the tunc-shop-logic branch July 5, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants