Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix !remaining #3611

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Core: Fix !remaining #3611

merged 2 commits into from
Jul 3, 2024

Conversation

remyjette
Copy link
Collaborator

@remyjette remyjette commented Jul 3, 2024

What is this fixing or adding?

Fix !remaining to no longer raise an AttributeError. Fixes https://discord.com/channels/731205301247803413/1257500354342555739

How was this tested?

Ran MultiServer.py with this fix. Connected with the text client. Ran !remaining and didn't get an exception.

If this makes graphical changes, please attach screenshots.

image

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 3, 2024
@remyjette remyjette added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jul 3, 2024
@NewSoupVi NewSoupVi merged commit f673574 into ArchipelagoMW:main Jul 3, 2024
17 checks passed
@remyjette remyjette deleted the fix-remaining branch July 3, 2024 13:52
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants