Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: "Fix" Priority Fill #3592

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Core: "Fix" Priority Fill #3592

wants to merge 3 commits into from
+14 −5

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Jun 26, 2024 •
edited
Loading

Read the related issue: #3467

@github-actions github-actions bot added the affects: core Issues/PRs that touch core and may need additional validation. label Jun 26, 2024
@NewSoupVi NewSoupVi marked this pull request as draft June 26, 2024 15:31
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 26, 2024
@korydondzila korydondzila mentioned this pull request Jun 28, 2024
Merged
@korydondzila
Copy link
Contributor

Really would like to see this get in, not just because the Shivers option we want to add... but seeing as 5.0 added the slew of options and group being priority locations... this might be important for anyone using those?

I mean like if I do this, this should be exactly what the option would be, which should run into the exact same issue we had with failed gens.
Screenshot 2024-07-13 at 20 39 44

@NewSoupVi NewSoupVi force-pushed the priorityfill_045_rocketsurgery branch from f0fb519 to 6de227e Compare August 6, 2024 18:47
@NewSoupVi NewSoupVi marked this pull request as ready for review August 6, 2024 18:47
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. labels Aug 8, 2024
korydondzila
korydondzila approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@korydondzila korydondzila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated seeds of 100 Shivers games where all Ixupi captures were priority.
On main it fails consistently to place a lot of items.
On this branch it generates successfully.

Exempt-Medic
Exempt-Medic approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change is fine and it fixes at least two worlds where I encountered generation problems. Tested it with Lingo and Shivers and the problems were removed/resolved.

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydondzila korydondzila korydondzila approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewSoupVi @korydondzila @Exempt-Medic