Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTTP: Add Missing Blind's Cell rule #3589

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Alchav
Copy link
Contributor

@Alchav Alchav commented Jun 24, 2024

What is this fixing or adding?

Adds a missing rule for Blind's Cell.

How was this tested?

Only generated to ensure no crash.

@Alchav Alchav requested a review from Berserker66 as a code owner June 24, 2024 11:20
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 24, 2024
@NewSoupVi NewSoupVi added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 24, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generation works, unit tests pass, code looks fine. Plando'ed a seed that passed on the old version and fails on this one

@Berserker66 Berserker66 merged commit 07dd8f0 into ArchipelagoMW:main Jun 25, 2024
17 checks passed
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants