Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer: Fix .apworld registration #3588

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

remyjette
Copy link
Collaborator

@remyjette remyjette commented Jun 24, 2024

What is this fixing or adding?

Fixes .apworld registration in Windows so users can double-click a .apworld to install it. Previously the registry entry for shell\open\command wasn't actually being added.

How was this tested?

Created an installer with this inno_setup.iss change, and installed Archipelago. Observed HKCR\Archipelagoworlddata\shell\open\command is now populated in regedit. Also checked my file associations in Windows, .apworld is now associated with Archipelago. Double-clicked pokemon_crystal.apworld and it was copied into custom_worlds with a success message.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 24, 2024
@remyjette remyjette added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 24, 2024
Copy link
Contributor

@benny-dreamly benny-dreamly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a simple enough change. didn't manage to test it, as I'm not too well versed in how to actually do that.

@remyjette
Copy link
Collaborator Author

I'm not too well versed in how to actually do that.

To build the installer, grab the Inno Setup compiler from https://jrsoftware.org/isinfo.php. Freeze the build with python build_exe in your venv. Open inno_setup.iss in the Inno Setup Compiler, comment out the SignTool= signtool line, then run.

@benny-dreamly
Copy link
Contributor

benny-dreamly commented Jun 24, 2024

I'm not too well versed in how to actually do that.

To build the installer, grab the Inno Setup compiler from https://jrsoftware.org/isinfo.php. Freeze the build with python build_exe in your venv. Open inno_setup.iss in the Inno Setup Compiler, comment out the SignTool= signtool line, then run.

oh thank you! I can test that for myself then.

EDIT: getting the testing setup, then I can report back :)

@benny-dreamly
Copy link
Contributor

I tested it, and used Yacht Dice as a test and it worked and copied the file into the custom_worlds folder. The file association was also made properly.

@Berserker66 Berserker66 merged commit 935c94d into ArchipelagoMW:main Jun 25, 2024
5 checks passed
@remyjette remyjette deleted the fix-apworld-registry branch June 25, 2024 18:25
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants