Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Messenger: Fix missing rules for Double Swing Saws #3562

Merged
merged 3 commits into from
Jun 19, 2024
Merged

The Messenger: Fix missing rules for Double Swing Saws #3562

merged 3 commits into from
Jun 19, 2024

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

Fixes a missing rule on the double swing saws seal.

How was this tested?

Wasn't, but there's no risk here. Only affects portal rando.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 18, 2024
ScipioWright
ScipioWright approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix matches how other rules look, unit tests just need updated probably.

@ScipioWright ScipioWright added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. affects: core Issues/PRs that touch core and may need additional validation. labels Jun 18, 2024
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 18, 2024
@Exempt-Medic
Copy link
Collaborator

I feel like updating one of both of your vertical unit tests probably makes sense here

@NewSoupVi NewSoupVi merged commit f515a08 into ArchipelagoMW:main Jun 19, 2024
17 checks passed
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@alwaysintreble @sflavelle
The Messenger: Fix missing rules for Double Swing Saws (ArchipelagoMW…
de7de40 
…#3562)

* The Messenger: Fix missing rules for Double Swing Saws

* i put it in the wrong dictionary

* remove unnecessary call
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@alwaysintreble @qwint
The Messenger: Fix missing rules for Double Swing Saws (ArchipelagoMW…
ea20153 
…#3562)

* The Messenger: Fix missing rules for Double Swing Saws

* i put it in the wrong dictionary

* remove unnecessary call
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
@alwaysintreble @GameWyrm
The Messenger: Fix missing rules for Double Swing Saws (ArchipelagoMW…
a86ed54 
…#3562)

* The Messenger: Fix missing rules for Double Swing Saws

* i put it in the wrong dictionary

* remove unnecessary call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alwaysintreble @Exempt-Medic @ScipioWright @NewSoupVi