Aquaria: Add entrance rule and fix start_inventory_from_pool #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: bug/fix
ScipioWright
approved these changes
Jun 7, 2024
Jouramie
approved these changes
Jun 10, 2024
ScipioWright
added
waiting-on: core-review
NewSoupVi
added
waiting-on: peer-review
|
Would like someone (1 person is enough) to now confirm the correctness of the location name change. Putting this back on peer review |
ScipioWright
approved these changes
Jun 11, 2024
ScipioWright
added
waiting-on: core-review
#3435) * Remove Muse Dash Regions. * Update comments.
ThePhar
approved these changes
Jun 11, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
After a run, I discover that the Sun form ability was needed to enter the Sunken city boss area. So I added the rule.
Also, the
start_inventory_from_pooloption was not working because I was manually removing the precollected item from the itempool. So when Archipelago tries to do the work, it could not find the item to remove in the itempool.How was this tested?
I test it by generating games with different options (including
start_inventory_from_poolandstart_inventoryoptions) and by using unit testing.