Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weighted-options page crashing if a Choice option's default is "random" #3458

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

LegendaryLinux
Copy link
Member

What is this fixing or adding?

See title.

How was this tested?

Run locally and tested that weighted-options pages with Choice and TextChoice options whose defaults' were "random" loaded properly.

@LegendaryLinux LegendaryLinux self-assigned this Jun 4, 2024
@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 4, 2024
@LegendaryLinux LegendaryLinux added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 4, 2024
@Exempt-Medic Exempt-Medic added the affects: release/blocker Issues/PRs that must be addressed before next official release. label Jun 7, 2024
Copy link
Member

@Berserker66 Berserker66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but code looks like it should do the right thing.

@LegendaryLinux LegendaryLinux merged commit 39deef5 into main Jun 8, 2024
17 checks passed
@LegendaryLinux LegendaryLinux deleted the random-fix branch June 8, 2024 08:54
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants