Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HK: Fix Egg_Shop typo in costsanity #3447

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

qwint
Copy link
Contributor

@qwint qwint commented Jun 3, 2024

What is this fixing or adding?

fixes a typo in costsanity code that checked for the wrong eggshop basename

How was this tested?

generated with my normal costsanity settings: saw geo in eggshop
rerolled after the fix: saw only non-geo costs in eggshop

If this makes graphical changes, please attach screenshots.

@qwint qwint requested a review from ThePhar as a code owner June 3, 2024 00:45
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 3, 2024
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested various cost weights, the change works.

@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 3, 2024
@NewSoupVi NewSoupVi merged commit 6432560 into ArchipelagoMW:main Jun 3, 2024
16 checks passed
@qwint qwint deleted the hk_eggshop_geo branch June 3, 2024 15:09
wu4 pushed a commit to wu4/Archipelago that referenced this pull request Jun 6, 2024
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
qwint added a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants