Pokemon Emerald: Fix possible dexsanity/legendary hunt softlock #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zunawe
added
the
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
reviewed
Jun 2, 2024
Exempt-Medic
approved these changes
Jun 2, 2024
Co-authored-by: Exempt-Medic <[email protected]>
Zunawe
added
waiting-on: core-review
NewSoupVi
approved these changes
Jun 4, 2024
wu4
pushed a commit
to wu4/Archipelago
that referenced
this pull request
Jun 6, 2024
…ipelagoMW#3443) * Pokemon Emerald: Remove mirage tower from allowed dexsanity maps * Pokemon Emerald: Prevent placing wailord/relicanth in out of logic maps * Pokemon Emerald: Clarify docstring Co-authored-by: Exempt-Medic <[email protected]> * Pokemon Emerald: Update changelog --------- Co-authored-by: Exempt-Medic <[email protected]>
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
…ipelagoMW#3443) * Pokemon Emerald: Remove mirage tower from allowed dexsanity maps * Pokemon Emerald: Prevent placing wailord/relicanth in out of logic maps * Pokemon Emerald: Clarify docstring Co-authored-by: Exempt-Medic <[email protected]> * Pokemon Emerald: Update changelog --------- Co-authored-by: Exempt-Medic <[email protected]>
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…ipelagoMW#3443) * Pokemon Emerald: Remove mirage tower from allowed dexsanity maps * Pokemon Emerald: Prevent placing wailord/relicanth in out of logic maps * Pokemon Emerald: Clarify docstring Co-authored-by: Exempt-Medic <[email protected]> * Pokemon Emerald: Update changelog --------- Co-authored-by: Exempt-Medic <[email protected]>
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…ipelagoMW#3443) * Pokemon Emerald: Remove mirage tower from allowed dexsanity maps * Pokemon Emerald: Prevent placing wailord/relicanth in out of logic maps * Pokemon Emerald: Clarify docstring Co-authored-by: Exempt-Medic <[email protected]> * Pokemon Emerald: Update changelog --------- Co-authored-by: Exempt-Medic <[email protected]>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…ipelagoMW#3443) * Pokemon Emerald: Remove mirage tower from allowed dexsanity maps * Pokemon Emerald: Prevent placing wailord/relicanth in out of logic maps * Pokemon Emerald: Clarify docstring Co-authored-by: Exempt-Medic <[email protected]> * Pokemon Emerald: Update changelog --------- Co-authored-by: Exempt-Medic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Mirage Tower disappears permanently if the player picks up the fossil at the top, so its encounters should not be considered logical access to a species. This counts for dexsanity and for placement of Wailord and Relicanth for legendary hunt.
How was this tested?
Generated a few times with dexsanity and legendary hunt goal.