TUNIC: Fix plando connections, seed groups, and UT support #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd also UT not functioning properly anymore
ScipioWright
added
is: bug/fix
…usage of Tunic in a class name. Fix typing on plando for SeedGroup
ThePhar
approved these changes
Jun 3, 2024
wu4
pushed a commit
to wu4/Archipelago
that referenced
this pull request
Jun 6, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes plando connection + seed groups support. For appending things in the new plando connections system, I need to add
.value.Fixes seed groups. For getting whether a custom string is used, I now need to compare to
EntranceRando.options.values()instead of justEntranceRando.optionslike before.Fixes a Universal Tracker support issue. If fixed shop is off in the yaml, it removes the Zig Skip Exit portal from the portal map. So if the slot has fixed shop on, and the yaml doesn't, it would mismatch. Since this option does not get loaded into slot data (since it is unnecessary for trackers), I had to write a quick thing to fix that up.
How was this tested?
Many test gens with weird yamls. Lots of triggers, plando connections, etc.
If this makes graphical changes, please attach screenshots.
N/A