Aquatia: Locations name changed due to typo's, grammar, or inconsistencies #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th capitalization
github-actions
bot
added
the
waiting-on: peer-review
nicholassaylor
approved these changes
May 31, 2024
ScipioWright
approved these changes
May 31, 2024
worlds/aquaria/Locations.py
Outdated
Comment on lines
162
to
163
| "Simon says area, beating Simon says": 698156, | ||
| "Simon says area, Transturtle": 698216, |
There was a problem hiding this comment.
Suggested change
| "Simon says area, beating Simon says": 698156, | |
| "Simon says area, Transturtle": 698216, | |
| "Simon Says area, beating Simon Says": 698156, | |
| "Simon Says area, Transturtle": 698216, |
Would recommend capitalizing "Says" here, since "Simon Says" is the name of a game, so it's grammatically correct to capitalize both words
There was a problem hiding this comment.
Here. I think that I found them all.
ScipioWright
added
is: bug/fix
ThePhar
approved these changes
Jun 1, 2024
wu4
pushed a commit
to wu4/Archipelago
that referenced
this pull request
Jun 6, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Modification of some Location names for typo, grammar or so that every one of them respect the same kind of capitalizations.
How was this tested?
I use unit testiing and try to generate games with different kind of options.