SC2: Fix Kerrigan Primal Form on Half Completion #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Ziktofel
added
the
is: bug/fix
Ziktofel
approved these changes
May 29, 2024
Berserker66
reviewed
May 29, 2024
|
it sums |
Co-authored-by: Fabian Dill <[email protected]>
|
I've tested and applied the suggested change. As Ziktofel explained, this is a sum of bools. It could be clearer that it's that, but we use this pattern in multiple places, so changing it would increase the scope of this PR quite a bit. |
ScipioWright
added
waiting-on: core-review
Berserker66
approved these changes
May 30, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes the
half_completionvalue for thekerrigan_primal_statusoption incorrectly counting completed missions.How was this tested?
Generating a seed with 5 missions and comparing Kerrigan primal status in-game after 2 completed missions and after 3 completed missions.