Core: Rename "count_exclusive" methods to "count_unique" #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
|
Oh it messes up some lint stuff. Will fix that in a moment |
|
You'll want to fix this too |
|
Ye my b, I hadn't actually done the group functions yet |
NewSoupVi
added
the
waiting-on: world-maintainer
|
@Rensen3 I can't request a review from you through github so pinging you instead |
ThePhar
added
is: refactor/cleanup
|
looks good to me |
Berserker66
approved these changes
May 24, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…MW#3386) * rename exclusive to unique * lint * group as well
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…MW#3386) * rename exclusive to unique * lint * group as well
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…MW#3386) * rename exclusive to unique * lint * group as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this poll https://discord.com/channels/731205301247803413/1243111773419339847/1243199985797828658
Will undraft once that poll finishes, although it's looking like everyone is unanimously on board with this change so far.
We haven't released a major stable version with the
exclusivevariants in it yet, so this change can still be made without making any aliases. Requires changing some worlds tho that have already started using these methods.