-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUNIC: Add option presets #3377
Merged
NewSoupVi
merged 3 commits into
ArchipelagoMW:main
from
ScipioWright:tunic-option-presets
May 23, 2024
Merged
TUNIC: Add option presets #3377
NewSoupVi
merged 3 commits into
ArchipelagoMW:main
from
ScipioWright:tunic-option-presets
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
added
the
is: enhancement
Issues requesting new features or pull requests implementing new features.
label
May 22, 2024
github-actions
bot
added
the
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
label
May 22, 2024
Exempt-Medic
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM (ran WebHost to check)
nicholassaylor
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, also tested on WebHost
Exempt-Medic
added
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
and removed
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
May 23, 2024
NewSoupVi
approved these changes
May 23, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* Add option presets * why the hell is there an s here * entrance rando yes
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
* Add option presets * why the hell is there an s here * entrance rando yes
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* Add option presets * why the hell is there an s here * entrance rando yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: enhancement
Issues requesting new features or pull requests implementing new features.
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds a few option presets for TUNIC. The first two to give a little recommendation for someone unsure what to bring to a sync or async. The third to punish the curious.
How was this tested?
Ran webhost, made sure the presets worked as intended. Ran tests.
If this makes graphical changes, please attach screenshots.
N/A