CustomServer: properly 'inherit' Archipelago from static_server_data #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a potential exception during room spin-up.
github-actions
bot
added
affects: webhost
|
#3341 was incomplete and could throw exceptions when starting. This PR fixes that. |
Berserker66
approved these changes
May 24, 2024
Exempt-Medic
added
the
is: bug/fix
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…rchipelagoMW#3366) This fixes a potential exception during room spin-up.
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…rchipelagoMW#3366) This fixes a potential exception during room spin-up.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…rchipelagoMW#3366) This fixes a potential exception during room spin-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential exception during room spin-up.
What is this fixing or adding?
https://discord.com/channels/731205301247803413/731214280439103580/1242434692234481795
How was this tested?
Spinning up webhost, connecting to an "unsupported" and a "supported" game and receiving the Datapackage for 'Archipelago' in both cases.