Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA2B: Option Groups and Dataclass #3357

Merged
merged 3 commits into from
May 21, 2024
Merged

SA2B: Option Groups and Dataclass #3357

merged 3 commits into from
May 21, 2024

Conversation

PoryGone
Copy link
Collaborator

What is this fixing or adding?

Option Groups and Dataclass for Sonic Adventure 2: Battle

How was this tested?

I ran the WebHost and see the Option Groups.
I generated template YAMLs from the launcher and saw the group headers.
I ran generations and validated option output.

If this makes graphical changes, please attach screenshots.

image

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 21, 2024
@PoryGone PoryGone mentioned this pull request May 21, 2024
Open
65 tasks
@PoryGone PoryGone added is: enhancement Issues requesting new features or pull requests implementing new features. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. labels May 21, 2024
@PoryGone
Copy link
Collaborator Author

Yes, general options seems redundant with the default group right there, but we like keeping those things separate from the general AP settings in the default group.

@LegendaryLinux LegendaryLinux merged commit 5c66681 into ArchipelagoMW:main May 21, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@PoryGone
SA2B: Option Groups and Dataclass (ArchipelagoMW#3357)
08b46eb 
* Merge Conflicts

* SA2B: Option Groups

* Re-add erroneously-removed import
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@PoryGone @sflavelle
SA2B: Option Groups and Dataclass (ArchipelagoMW#3357)
5fd5953 
* Merge Conflicts

* SA2B: Option Groups

* Re-add erroneously-removed import
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@PoryGone @qwint
SA2B: Option Groups and Dataclass (ArchipelagoMW#3357)
263fa0d 
* Merge Conflicts

* SA2B: Option Groups

* Re-add erroneously-removed import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegendaryLinux LegendaryLinux LegendaryLinux approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PoryGone @LegendaryLinux