-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUNIC: Use fewer parameters in helper functions #3356
TUNIC: Use fewer parameters in helper functions #3356
Conversation
For what it's worth, I definitely would have preferred passing world and getting player from world.player and multiworld from world.multiworld It's the same number of args ( Ftr, I don't think there is anything technically wrong with what you're doing here though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem to be the same thing over and over a million times. And that thing seems like a good one. So approved
What is this fixing or adding?
Tunic had a bunch of ruler helper functions with way too many parameters.
Now they don't!
How was this tested?
Ran gen a few times, zipped it into an apworld and ran gen on frozen just in case
If this makes graphical changes, please attach screenshots.
N/A