Landstalker: Fixed rare generation issues #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: bug/fix
Berserker66
reviewed
May 23, 2024
Co-authored-by: Fabian Dill <[email protected]>
ThePhar
approved these changes
Jun 1, 2024
wu4
pushed a commit
to wu4/Archipelago
that referenced
this pull request
Jun 6, 2024
Co-authored-by: Fabian Dill <[email protected]>
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
Co-authored-by: Fabian Dill <[email protected]>
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Fabian Dill <[email protected]>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Co-authored-by: Fabian Dill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This fixes generation bugs reported in the following Discord threads:
https://discord.com/channels/731205301247803413/1199949415373344798
https://discord.com/channels/731205301247803413/1225442951447187456
These issues were caused by three different causes:
can_reachin an unreliable way, those were replaced by eventsmultiworld.randombeing used instead ofworld.random. This was not reported but I preferred to fix it.How was this tested?
This was tested by generating hundreds of seeds with various option combinations each.
Not a single one caused a generation issue.
Logic was manually analyzed for a few seeds to ensure can_reach replacement events are well tested, and playthrough made perfect sense while using events.