Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lingo: Add option groups #3352

Merged
merged 2 commits into from
May 23, 2024
Merged

Lingo: Add option groups #3352

merged 2 commits into from
May 23, 2024

Conversation

hatkirby
Copy link
Collaborator

What is this fixing or adding?

Added two option groups: "pilgrimage" and "fine-tuning". Options that don't fall into those groups are just in the default group.

How was this tested?

Looked at the webhost.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 20, 2024
@hatkirby hatkirby added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 20, 2024
ScipioWright
ScipioWright approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is formatted correctly

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 20, 2024
LegendaryLinux
LegendaryLinux approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@LegendaryLinux LegendaryLinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to also update your docstrings to adjust the text formatting in tooltips on /player-options. Up to you.

@NewSoupVi NewSoupVi merged commit 8b6eae0 into ArchipelagoMW:main May 23, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@hatkirby
Lingo: Add option groups (ArchipelagoMW#3352)
79ea15d 
* Lingo: Add option groups

* Touched up option docstrings
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@hatkirby @sflavelle
Lingo: Add option groups (ArchipelagoMW#3352)
accc404 
* Lingo: Add option groups

* Touched up option docstrings
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@hatkirby @qwint
Lingo: Add option groups (ArchipelagoMW#3352)
0583567 
* Lingo: Add option groups

* Touched up option docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegendaryLinux LegendaryLinux LegendaryLinux approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hatkirby @LegendaryLinux @ScipioWright @NewSoupVi