Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pokemon RB: Add an item group for each HM to improve hinting #3311

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Pokemon RB: Add an item group for each HM to improve hinting #3311

merged 2 commits into from
Jun 3, 2024

Conversation

remyjette
Copy link
Collaborator

@remyjette remyjette commented May 16, 2024 •
edited
Loading

What is this fixing or adding?

HMs are suffixed with the name of the move, e.g. "HM02 Fly". If TM move are randomized, they do not have the move name, e.g. "TM02".

If someone hints for an HM using the just the number, the fuzzy matching sees "TM02" as closer than "HM02 Fly", and in fact sees it as close enough to not ask the user to confirm, leading them to waste hint points on non-progression item that they didn't intend.

Emerald already does this for this reason, adding the same for RB.

How was this tested?

Hinted for an HM via !hint HM02 before and after this change.

If this makes graphical changes, please attach screenshots.

Before:
image

After:
image

@remyjette
Pokemon RB: Add an item group for each HM
823af8d 
HMs are suffixed with the name of the move, e.g. "HM02 Fly". If TM
move are randomized, they do not have the move name, e.g. "TM02".

If someone hints for an HM using the just the number, the fuzzy matching
sees "TM02" as closer than "HM02 Fly", and in fact sees it as close
enough to not ask the user to confirm, leading them to waste hint points
on non-progression item that they didn't intend.

Emerald already does this for this reason, adding the same for RB.
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 16, 2024
@remyjette
Copy link
Collaborator Author

@Alchav

@remyjette remyjette added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels May 16, 2024
Alchav
Alchav reviewed May 17, 2024
View reviewed changes
worlds/pokemon_rb/items.py Outdated Show resolved Hide resolved
@remyjette remyjette removed the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label May 17, 2024
Exempt-Medic
Exempt-Medic approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes through generations and using the text client to hint. Correctly prevented the fuzzymatching errors and instead hinted the HMs.

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 1, 2024
alwaysintreble
alwaysintreble approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@alwaysintreble alwaysintreble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple change looks fine

@NewSoupVi NewSoupVi merged commit 424c8b0 into ArchipelagoMW:main Jun 3, 2024
16 checks passed
wu4 pushed a commit to wu4/Archipelago that referenced this pull request Jun 6, 2024
@remyjette @wu4
Pokemon RB: Add an item group for each HM to improve hinting (Archipe…
0654899 
…lagoMW#3311)

* Pokemon RB: Add an item group for each HM

HMs are suffixed with the name of the move, e.g. "HM02 Fly". If TM
move are randomized, they do not have the move name, e.g. "TM02".

If someone hints for an HM using the just the number, the fuzzy matching
sees "TM02" as closer than "HM02 Fly", and in fact sees it as close
enough to not ask the user to confirm, leading them to waste hint points
on non-progression item that they didn't intend.

Emerald already does this for this reason, adding the same for RB.

* Add the new groups for HMs in the item_table instead
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
@remyjette @agilbert1412
Pokemon RB: Add an item group for each HM to improve hinting (Archipe…
9a2c8c0 
…lagoMW#3311)

* Pokemon RB: Add an item group for each HM

HMs are suffixed with the name of the move, e.g. "HM02 Fly". If TM
move are randomized, they do not have the move name, e.g. "TM02".

If someone hints for an HM using the just the number, the fuzzy matching
sees "TM02" as closer than "HM02 Fly", and in fact sees it as close
enough to not ask the user to confirm, leading them to waste hint points
on non-progression item that they didn't intend.

Emerald already does this for this reason, adding the same for RB.

* Add the new groups for HMs in the item_table instead
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@remyjette
Pokemon RB: Add an item group for each HM to improve hinting (Archipe…
3d639ff 
…lagoMW#3311)

* Pokemon RB: Add an item group for each HM

HMs are suffixed with the name of the move, e.g. "HM02 Fly". If TM
move are randomized, they do not have the move name, e.g. "TM02".

If someone hints for an HM using the just the number, the fuzzy matching
sees "TM02" as closer than "HM02 Fly", and in fact sees it as close
enough to not ask the user to confirm, leading them to waste hint points
on non-progression item that they didn't intend.

Emerald already does this for this reason, adding the same for RB.

* Add the new groups for HMs in the item_table instead
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@remyjette @sflavelle
Pokemon RB: Add an item group for each HM to improve hinting (Archipe…
1efb62a 
…lagoMW#3311)

* Pokemon RB: Add an item group for each HM

HMs are suffixed with the name of the move, e.g. "HM02 Fly". If TM
move are randomized, they do not have the move name, e.g. "TM02".

If someone hints for an HM using the just the number, the fuzzy matching
sees "TM02" as closer than "HM02 Fly", and in fact sees it as close
enough to not ask the user to confirm, leading them to waste hint points
on non-progression item that they didn't intend.

Emerald already does this for this reason, adding the same for RB.

* Add the new groups for HMs in the item_table instead
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@remyjette @qwint
Pokemon RB: Add an item group for each HM to improve hinting (Archipe…
e17bbed 
…lagoMW#3311)

* Pokemon RB: Add an item group for each HM

HMs are suffixed with the name of the move, e.g. "HM02 Fly". If TM
move are randomized, they do not have the move name, e.g. "TM02".

If someone hints for an HM using the just the number, the fuzzy matching
sees "TM02" as closer than "HM02 Fly", and in fact sees it as close
enough to not ask the user to confirm, leading them to waste hint points
on non-progression item that they didn't intend.

Emerald already does this for this reason, adding the same for RB.

* Add the new groups for HMs in the item_table instead
@remyjette remyjette deleted the pokemon-rb-hm-item-groups branch July 8, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@Alchav Alchav Alchav approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@alwaysintreble alwaysintreble alwaysintreble approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@remyjette @alwaysintreble @NewSoupVi @Alchav @Exempt-Medic