Docs: Update advanced yaml guide wording for priority locations #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
added
the
is: documentation
github-actions
bot
added
the
waiting-on: peer-review
ShinyNT
approved these changes
May 13, 2024
|
May want to also change options api.md mentioning excluded locations |
Exempt-Medic
approved these changes
May 14, 2024
ScipioWright
added
waiting-on: core-review
Exempt-Medic
approved these changes
May 14, 2024
NewSoupVi
approved these changes
May 14, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…ipelagoMW#3298) * Update advanced yaml guide wording * Update options api as well * Update exclude locations description slightly to use more current verbiage * Update priority locations in options api.md to note what happens if it runs out * Remove auto-added bullet points * Slightly mess with wording to make it more succinct
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…ipelagoMW#3298) * Update advanced yaml guide wording * Update options api as well * Update exclude locations description slightly to use more current verbiage * Update priority locations in options api.md to note what happens if it runs out * Remove auto-added bullet points * Slightly mess with wording to make it more succinct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Currently, it says that priority_locations is the inverse of exclude_locations. This is not true, since neither exclude_locations nor priority_locations allow useful items.
I'm not a huge fan of the wording, I'm mostly just mirroring the exclude_locations text.
How was this tested?
Reading
If this makes graphical changes, please attach screenshots.
N/A