Hylics 2: Remove Random Start option and replace it with Start Location option #3289
Conversation
github-actions
bot
added
the
waiting-on: peer-review
TRPG0
added
the
is: enhancement
| "random_start" : self.options.random_start.value, | ||
| "start_location" : self.start_location, | ||
| "random_start": int(self.options.start_location != "waynehouse"), | ||
| "start_location" : self.options.start_location.current_option_name, |
There was a problem hiding this comment.
I assume this is meant to use the capitalized forms, with spaces, and the other small changes? So waynehouse -> Waynehouse, viewaxs_edifice -> Viewax's Edifice, and so on? I just ask because the docstring says "For display purposes. Worlds should be using current_key."
There was a problem hiding this comment.
Yes, that's why I used current_option_name instead. I did the same thing when implementing an option for A Short Hike a while back.
There was a problem hiding this comment.
The back-compat line functions correctly. Code/changes LGTM. It generates just fine. Only suggestion, you may want to add random_start as a Removed option so that old yamls using it on newer AP will throw an error instead of silently using the default.
Update: The new removed option works properly
|
Random Overcooked 2! test failure... |
Exempt-Medic
added
waiting-on: core-review
…on option (ArchipelagoMW#3289) * Hylics 2: Remove Random Start option and replace it with Start Location option * remove choice * Readd random start to slot data * newlines * Add random_start as a Removed option
…on option (ArchipelagoMW#3289) * Hylics 2: Remove Random Start option and replace it with Start Location option * remove choice * Readd random start to slot data * newlines * Add random_start as a Removed option
Removes the Random Start option from Hylics 2 and replaces it with the Start Location option, allowing the player to select a specific starting location in addition to having it randomly chosen.
@TRPG0