Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: prevent "Could not find identify Component responsible for None" from being logged. #3225

Merged
merged 1 commit into from
May 17, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Should fix the message appearing in places like https://discord.com/channels/731205301247803413/1214608557077700720/1233912447933481006

How was this tested?

Made adventure into an apworld and somehow that triggers it.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 27, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 28, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how exactly that exception happened, but this change should be fine.

@Berserker66 Berserker66 merged commit 3dbdd04 into main May 17, 2024
26 checks passed
@Berserker66 Berserker66 deleted the core_dont_search_component_none branch May 17, 2024 10:19
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants