Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOT: Add keys item_name_group #3218

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Conversation

ScipioWright
Copy link
Collaborator

@ScipioWright ScipioWright commented Apr 26, 2024

What is this fixing or adding?

Adds an item_name_group for keys.
There was discussion on which settings for OoT slow down gen, in the context of the big async. One of them was small key shuffle being set to one of the options that makes the small keys in your own world. Since there's potential of this option being meta'd off, I figure there should be a convenient way to make the keys local if you want them to be that is separate from the option.

How was this tested?

Ran gen, did /item_groups

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 26, 2024
@Exempt-Medic Exempt-Medic added waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. is: enhancement Issues requesting new features or pull requests implementing new features. labels Apr 26, 2024
@PoryGone
Copy link
Collaborator

My question, as someone who doesn't play OoT, is what does that ostensibly slow custom option do that makes it so much slower than just making small keys local?

@ScipioWright
Copy link
Collaborator Author

ScipioWright commented Apr 26, 2024

My question, as someone who doesn't play OoT, is what does that ostensibly slow custom option do that makes it so much slower than just making small keys local?

It places them into a random location in their original dungeon, in regions near their original dungeon, in the overworld, or in any dungeon (each of these are different choices for the option)

This PR would speed those placements up: #2415

Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New group makes sense, works, and includes every type of Key. Just needs @espeon65536

@NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi removed the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Jun 20, 2024
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 20, 2024
@NewSoupVi NewSoupVi merged commit 31bd5e3 into ArchipelagoMW:main Jun 29, 2024
16 checks passed
@ScipioWright ScipioWright deleted the patch-1 branch June 30, 2024 02:24
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
* Add keys item_name_group

* Pep8ify

* Capitalizing Keys cause Bottles is capitalized, also putting it in the clearly marked hint groups area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants