-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OOT: Add keys item_name_group #3218
Conversation
My question, as someone who doesn't play OoT, is what does that ostensibly slow custom option do that makes it so much slower than just making small keys local? |
It places them into a random location in their original dungeon, in regions near their original dungeon, in the overworld, or in any dungeon (each of these are different choices for the option) This PR would speed those placements up: #2415 |
…e clearly marked hint groups area
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New group makes sense, works, and includes every type of Key. Just needs @espeon65536
Approval from Espeon is implicit as per https://discord.com/channels/731205301247803413/1214608557077700720/1253206955879694336 |
* Add keys item_name_group * Pep8ify * Capitalizing Keys cause Bottles is capitalized, also putting it in the clearly marked hint groups area
What is this fixing or adding?
Adds an item_name_group for keys.
There was discussion on which settings for OoT slow down gen, in the context of the big async. One of them was small key shuffle being set to one of the options that makes the small keys in your own world. Since there's potential of this option being meta'd off, I figure there should be a convenient way to make the keys local if you want them to be that is separate from the option.
How was this tested?
Ran gen, did /item_groups
If this makes graphical changes, please attach screenshots.
N/A