WebHost: use a limited process pool to run Rooms #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berserker66
added
meta: help wanted
github-actions
bot
added
the
affects: core
remyjette
reviewed
May 14, 2024
| run_guardian() | ||
| cleanup() | ||
| hosters = [] | ||
| for x in range(config["HOSTERS"]): |
There was a problem hiding this comment.
could HOSTERS be added to docs/webhost configuration sample.yaml ?
Berserker66
added a commit
that referenced
this pull request
May 18, 2024
(cherry picked from commit 7900e4c)
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Should drastically reduce the memory requirements on WebHost by consolidating Rooms onto a few Processes, instead of one each.
How was this tested?
A bit locally. Logging is entirely broken.
Only on Windows 10 so far.
Future
I don't know how best to solve the logging problem. Ideas or PR'd solutions are certainly welcome.
There's probably some data overlap between Rooms that can now be "exploited" to consilidate RAM use, I haven't checked, but I would guess that currently each room still has a full copy of its datapackage, with no sharing.
There is one print in there currently, due to logging being broken and me otherwise not seeing the message.