Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Fix Monastery Entry Right Requirement #3213

Merged
merged 1 commit into from
May 17, 2024
Merged

The Witness: Fix Monastery Entry Right Requirement #3213

merged 1 commit into from
May 17, 2024

Conversation

NewSoupVi
Copy link
Member

Another thing that cannot possibly matter right now, but who knows about the future

@NewSoupVi NewSoupVi added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 25, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 25, 2024
ScipioWright
ScipioWright approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same as the thing below it, the 0x00B10. As long as that's right, then the syntax looks fine, and I trust that you know the logic

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 25, 2024
hatkirby
hatkirby approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic checks out.

black-sliver
black-sliver approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know witness logic, but the change looks fine.

@NewSoupVi NewSoupVi merged commit 9ae7083 into ArchipelagoMW:main May 17, 2024
10 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@NewSoupVi
Fix Monastery Entry RIght righqeuotghqeougtfgas (ArchipelagoMW#3213)
b9d727a
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@NewSoupVi @qwint
Fix Monastery Entry RIght righqeuotghqeougtfgas (ArchipelagoMW#3213)
a96e0a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatkirby hatkirby hatkirby approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewSoupVi @hatkirby @ScipioWright @black-sliver