Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: remove JSON_AS_ASCII #3209

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Last time I saw this option it came with a deprecationwarning, so it's either already removed or no longer relevant.

How was this tested?

Nah

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 24, 2024
@ThePhar ThePhar added the affects: webhost Issues/PRs that touch webhost and may need additional validation. label Apr 24, 2024
Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it was removed from flask as of v2.3 and considering we use 3.x, I think it's safe to say we don't need it either.

@Berserker66 Berserker66 merged commit 4756c76 into main Apr 24, 2024
3 checks passed
@Berserker66 Berserker66 deleted the webhost_remove_json_as_ascii branch April 24, 2024 04:36
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants