-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC2: For non-campaign order pick one of the hardest missions as goal #3180
Conversation
This allows End Game as the goal even if long campaigns are present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran some test gens and it handles the use case that I originally brought up and then some. I still think that in the scenario my test case brought up but instead of grid we used one of the two mission orders Zik specifically said this doesn't cover, that End Game should get shunted up into the WoL campaign and be the final mission, but I understand that there'd have to be a lot more shunting around of things to get that particular scenario to work. So approving this since it does what I desired to happen with my original use case.
Yeah, shunting End Game into WoL's lane while thinking about all the consequences takes more work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and it works as expected. Mission plando and more mission orders in the future should help with the edge cases.
I think a lot of users are using Vanilla Shuffled/Mini Campaign because they just don't want to play with the grid/blitz/gauntlet styles, so if they don't prefer the faithfulness to vanilla that those mission orders are about, new mission orders should satisfy them.
…rchipelagoMW#3180) This allows End Game as the goal even if long campaigns are present
…rchipelagoMW#3180) This allows End Game as the goal even if long campaigns are present
What is this fixing or adding?
If the mission order isn't
vanilla_shuffled
ormini_campaign
, pick just one of the hardest missions that's enabled and make it goal.This allows End Game as the goal even if long campaigns are present
How was this tested?
Generated a couple of games with various YAMLs, subject to goal selection
If this makes graphical changes, please attach screenshots.
No