Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC2: For non-campaign order pick one of the hardest missions as goal #3180

Merged
merged 1 commit into from
May 2, 2024

Conversation

Ziktofel
Copy link
Collaborator

What is this fixing or adding?

If the mission order isn't vanilla_shuffled or mini_campaign, pick just one of the hardest missions that's enabled and make it goal.

This allows End Game as the goal even if long campaigns are present

How was this tested?

Generated a couple of games with various YAMLs, subject to goal selection

If this makes graphical changes, please attach screenshots.

No

This allows End Game as the goal even if long campaigns are present
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 19, 2024
@Ziktofel Ziktofel added the is: enhancement Issues requesting new features or pull requests implementing new features. label Apr 19, 2024
Copy link
Collaborator

@t3hf1gm3nt t3hf1gm3nt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran some test gens and it handles the use case that I originally brought up and then some. I still think that in the scenario my test case brought up but instead of grid we used one of the two mission orders Zik specifically said this doesn't cover, that End Game should get shunted up into the WoL campaign and be the final mission, but I understand that there'd have to be a lot more shunting around of things to get that particular scenario to work. So approving this since it does what I desired to happen with my original use case.

@Ziktofel
Copy link
Collaborator Author

Yeah, shunting End Game into WoL's lane while thinking about all the consequences takes more work.
I think myself, that'd get resolved with mission plando as there will be more things to solve

Copy link
Contributor

@Magnemania Magnemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works as expected. Mission plando and more mission orders in the future should help with the edge cases.

I think a lot of users are using Vanilla Shuffled/Mini Campaign because they just don't want to play with the grid/blitz/gauntlet styles, so if they don't prefer the faithfulness to vanilla that those mission orders are about, new mission orders should satisfy them.

@Ziktofel Ziktofel added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 22, 2024
@NewSoupVi NewSoupVi merged commit 8c8b29a into ArchipelagoMW:main May 2, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
…rchipelagoMW#3180)

This allows End Game as the goal even if long campaigns are present
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
…rchipelagoMW#3180)

This allows End Game as the goal even if long campaigns are present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants