LttP: fix percentage Triforce Pieces and missed cleanup from #3160 #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Alchav
approved these changes
Apr 19, 2024
ThePhar
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
confirmed this fixed issues I brought up here: https://discord.com/channels/731205301247803413/1214608557077700720/1230733993826189363
Going to wait for @Berserker66 to give final say though, but LGTM
ThePhar
added
is: bug/fix
beauxq
reviewed
Apr 19, 2024
| @@ -682,7 +682,7 @@ def place_item(loc, item): | |||
| triforce_pieces = world.triforce_pieces_available[player].value + world.triforce_pieces_extra[player].value | |||
| elif world.triforce_pieces_mode[player].value == TriforcePiecesMode.option_percentage: | |||
| percentage = float(world.triforce_pieces_percentage[player].value) / 100 | |||
| triforce_pieces = round(world.triforce_pieces_required[player].value * percentage, 0) | |||
| triforce_pieces = int(round(world.triforce_pieces_required[player].value * percentage, 0)) | |||
There was a problem hiding this comment.
another way is to remove the 0 parameter from round
Berserker66
approved these changes
Apr 19, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Changes a use of
self.swordlessandself.glitches_requiredtoself.multiworld.swordless[self.player]andself.multiworld.glitches_required[self.player]respectively.Round returns the datatype that was passed in, so we cast the resulting float to an int when on percentage Triforce Pieces.
How was this tested?
Generated using the offending yaml.
If this makes graphical changes, please attach screenshots.