CV64: Use AP Procedure Patch #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: enhancement
Berserker66
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Changes some stuff in CV64's generate_output to have it use the new AP Procedure Patch. Single game gen times now take milliseconds instead of seconds thanks to no longer needing to wait on bsdiff, and the ROM is no longer needed to generate.
How was this tested?
Took my ROM out of my source directory and went through the entire process of generating and patching to make sure it didn't ask for the ROM until opening the patch through the launcher. And then played the seed to completion to make sure everything in the game was working as it should.
NOTE: This PR includes the fixes from #3129. If this merges first, feel free to close it (or I will).