Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heretic: Update to use new Options + logic fixes + Doc fix #3139

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Heretic: Update to use new Options + logic fixes + Doc fix #3139

merged 2 commits into from
Apr 18, 2024

Conversation

Daivuk
Copy link
Collaborator

@Daivuk Daivuk commented Apr 13, 2024

What is this fixing or adding?

  • Changed old Options to use the new https://github.com/DataClass options
  • Added info in doc on which folder to find your WAD file in your steam library
  • renamed variables world -> multiworld
  • Fixed issue where clearing boss stages didn't trigger victory
  • Fixed E4M8 not opening exit due to missing Lynch King with chaotic random
  • Fixed logic issue in E4M3
    image
  • Fixed logic issue in E3M2
    image
  • Fixed logic issues in E5M3
  • Fixed logic issue in E2M3
  • Fixed logic issue in E2M5
    image

How was this tested?

Locally. The logic issues were reported and logged months ago

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 13, 2024
@qwint
Copy link
Contributor

qwint commented Apr 13, 2024

wrong title?

@Daivuk Daivuk changed the title DOOM 1993: Update to use new Options + logic fixes + Doc fix Heretic: Update to use new Options + logic fixes + Doc fix Apr 13, 2024
@Daivuk
Copy link
Collaborator Author

Daivuk commented Apr 13, 2024

wrong title?

Yup. Fixed. They are all the same for me :D

@ScipioWright ScipioWright added the is: refactor/cleanup Improvements to code/output readability or organizization. label Apr 14, 2024
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: documentation Improvements or additions to documentation. labels Apr 14, 2024
@Berserker66 Berserker66 merged commit 2c80a9b into ArchipelagoMW:main Apr 18, 2024
15 checks passed
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Daivuk @qwint
Heretic: Update to use new Options + logic fixes + Doc fix (Archipela…
061f8c6 
…goMW#3139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: documentation Improvements or additions to documentation. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Daivuk @qwint @Berserker66 @ScipioWright @Exempt-Medic