-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhost: Fix a typo on Start Playing page #3122
Conversation
Out of scope perhaps, but since you're in here, two things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see "config file" being argued both ways since this text is aimed at people who are just learning AP for the first time, and jumping straight into Archipelago-specific jargon could be more intimidating than helpful.
Either way, the lack of "or" here is a pretty clear mistake we should fix.
For the sake of clarity, when uploading yamls to the site to generate a game, can you only upload player option yamls, or can you upload stuff like meta.yaml, host.yaml, or others I'm not thinking of too? |
At the generation page, you can upload either:
I see where you're coming from, but I don't know that I see "config file" as so much more generic of a term that it's worth the subsequent confusion when they go any further than this specific page and never see the term again. |
I'll probably just do something along the lines of "a yaml file (player options configuration file)" to make it a little clearer to a first-time player. |
I chose to use config as a generic term because something I would truly love is for normal users to never need to know what a YAML file is. Modifying them manually is in my opinion a power-user choice, or if it is not, it should be. Either way, I do not believe anyone is confused by the usage of the word "config." I do agree the wording could be updated to reflect the possibility of uploading "one or more config files, or a single zip file containing one or more config files." |
You'll need to upload either a config file or a zip file containing one more config files. | ||
You'll need to upload one or more config files (YAMLs) or a zip file containing one or more config files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just committed a change here. Thoughts?
* add an or * Changed the wording to account for uploading multiple files
* add an or * Changed the wording to account for uploading multiple files
* add an or * Changed the wording to account for uploading multiple files
What is this fixing or adding?
On the start playing page, it says "You'll need to upload either a config file or a zip file containing one more config files."
Instead of "one more", it should be "one or more".
How was this tested?
Standardized common core
If this makes graphical changes, please attach screenshots.
N/A