Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some worlds: some typing in LocalRom #3090

Merged
merged 6 commits into from
May 17, 2024

Commits on Apr 4, 2024

  1. some worlds: some typing in LocalRom

    ### `read_bytes`
    
    It's not safe to return `bytearray` when we think it's `bytes`
    ```python
    a = rom.read_bytes(8, 3)
    hash(a)  # This won't crash, right?
    ```
    
    ### `write_bytes`
    
    `Iterable[SupportsIndex]` is what's required for `bytearray.__setitem__(slice, values)`
    We need to add `__len__` for the `len(values)` in this function.
    beauxq committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8ba3fbe View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Configuration menu
    Copy the full SHA
    0f3cb0e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    06373b9 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    15d4bd0 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    2b7b0d7 View commit details
    Browse the repository at this point in the history
  2. remove object inheritance

    beauxq committed May 17, 2024
    Configuration menu
    Copy the full SHA
    58eb9cb View commit details
    Browse the repository at this point in the history