-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: improve contributing sign posting #2888
Merged
NewSoupVi
merged 6 commits into
ArchipelagoMW:main
from
alwaysintreble:roadsign_contributing
May 29, 2024
Merged
Docs: improve contributing sign posting #2888
NewSoupVi
merged 6 commits into
ArchipelagoMW:main
from
alwaysintreble:roadsign_contributing
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwaysintreble
added
is: documentation
Improvements or additions to documentation.
is: enhancement
Issues requesting new features or pull requests implementing new features.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
Mar 3, 2024
Exempt-Medic
reviewed
Mar 9, 2024
Exempt-Medic
reviewed
Mar 9, 2024
Exempt-Medic
reviewed
Mar 9, 2024
Exempt-Medic
added
the
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
label
Mar 9, 2024
alwaysintreble
removed
the
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
label
Mar 31, 2024
Exempt-Medic
added
the
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
label
Apr 5, 2024
Exempt-Medic
removed
the
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
label
May 9, 2024
Exempt-Medic
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
NewSoupVi
approved these changes
May 29, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* Docs: improve sign posting for contributing * fix styling as per the style guide * address review comments * apply medic's feedback
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
* Docs: improve sign posting for contributing * fix styling as per the style guide * address review comments * apply medic's feedback
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* Docs: improve sign posting for contributing * fix styling as per the style guide * address review comments * apply medic's feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: documentation
Improvements or additions to documentation.
is: enhancement
Issues requesting new features or pull requests implementing new features.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
improves sign posting for new devs, as the conversation starting here alludes it is not clear enough https://discord.com/channels/731205301247803413/731214280439103580/1213918637467902014
How was this tested?
📖