Lingo: The Pilgrim Update #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Colorful did not actually properly split into individual doors when progressive colorful was off. This change refactors the code that handles special cases with progressive items to make things clearer (which is important because I will be introducing another one).
Also fixed a classic lambda capture bug, and an over-eager event capture issue, that was making pilgrimage detection completely break.
We are no longer using sub-states to determine pilgrimage access. Instead, five additional subgraphs are created, each containing entrances with the same access rules as the original map, but filtered so only allowable connections exist. The only location in each subgraph is an event (possibly with an access rule) saying whether the end of the pilgrimage segment is reachable. This change was needed because on vanilla doors, the sub-states would assume that you couldn't open doors if there was no way to open it without using warps, even though in reality you can just open the door before starting the pilgrimage. Items have been refactored a bit too. player_logic is more responsible for which items get instantiated. This was needed because sunwarps are technically doors, but are separate from the shuffle_doors option; you can shuffle sunwarps and not shuffle doors. The sun painting is another special case.
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: enhancement
ScipioWright
approved these changes
Mar 15, 2024
Instead of each graph being completely separate, the graphs lead into each other at the sunwarps. No event items are needed at all.
hatkirby
added
the
waiting-on: other
NewSoupVi
reviewed
Apr 4, 2024
hatkirby
added
waiting-on: core-review
Berserker66
approved these changes
Apr 18, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* An option was added to enable or disable the pilgrimage, and it defaults to disabled. When disabled, the client will prevent you from performing a pilgrimage (i.e. the yellow border will not appear when you enter the 1 sunwarp). The sun painting is added to the item pool when pilgrimage is disabled, as otherwise there is no way into the Pilgrim Antechamber. Inversely, the sun painting is no longer in the item pool when pilgrimage is enabled (even if door shuffle is on), requiring you to perform a pilgrimage to get to that room. * The canonical pilgrimage has been deprecated. Instead, there is logic for determining whether a pilgrimage is possible. * Two options were added that allow the player to decide whether paintings and/or Crossroads - Roof Access are permitted during the pilgrimage. Both default to disabled. These options apply both to logical expectations in the generator, and are also enforced by the game client. * An option was added to control how sunwarps are accessed. The default is for them to always be accessible, like in the base game. It is also possible to disable them entirely (which is not possible when pilgrimage is enabled), or lock them behind items similar to door shuffle. It can either be one item that unlocks all sunwarps at the same time, six progressive items that unlock the sunwarps from 1 to 6, or six individual items that unlock the sunwarps in any order. This option is independent from door shuffle. * An option was added that shuffles sunwarps. This acts similarly to painting shuffle. The 12 sunwarps are re-ordered and re-paired. Sunwarps that were previously entrances or exits do not need to stay entrances or exits. Performing a pilgrimage requires proceeding through the sunwarps in the new order, rather than the original one. * Pilgrimage was added as a win condition. It requires you to solve the blue PILGRIM panel in the Pilgrim Antechamber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
A number of features related to sunwarps and the pilgrimage have been added.
How was this tested?
pytest and test runs. A beta test sync was conducted successfully.
Prerelease versions of the client and tracker are available for testing too:
Apworld: lingo.zip (Rename this to lingo.apworld)
Client: archipelago-sunwarps-beta4.zip
Tracker: lingo-ap-tracker-sunwarps-beta3-win64.zip