Core: add specific can_reach helpers to CollectionState #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwaysintreble
added
is: enhancement
Ixrec
approved these changes
Feb 26, 2024
|
LGTM Pretty sure using those would (very slightly) improve performances of stardew rules. Unfortunately, I don't really have time to benchmark. |
Jouramie
approved these changes
Feb 28, 2024
alwaysintreble
added
waiting-on: core-review
|
So I ended up benchmarking the Stardew 5.x.x branch with these new helpers instead of the usual |
black-sliver
approved these changes
Mar 3, 2024
github-actions
bot
removed
the
waiting-on: core-review
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds specific can_reach helpers to CollectionState so that passing a string and strict string comparisons are no longer necessary. Should be marginally faster but didn't benchmark it.
How was this tested?
Used the new helper in my world and made sure it was still passing logic tests. Existing can_reach also calls into the new helpers so any tests with logic related to those also hits this.
If this makes graphical changes, please attach screenshots.