SM: clean post_fill function

[beauxq]

What is this fixing or adding?

make this function easier to read and understand

How was this tested?

run this:

a = """
def get_player_ItemLocation(progression_only: bool):
        return [
                ItemLocation(copy.copy(ItemManager.Items[
                    itemLoc.item.type if isinstance(itemLoc.item, SMItem) and itemLoc.item.type in ItemManager.Items else
                    'ArchipelagoItem']),
                    copy.copy(locationsDict[itemLoc.name] if itemLoc.game == self.game else
                                locationsDict[first_local_collected_loc.name]),
                    itemLoc.item.player,
                    True)
                    for itemLoc in spheres if itemLoc.item.player == self.player and (not progression_only or itemLoc.item.advancement)
                ]
"""

b = """
def get_player_ItemLocation(progression_only: bool):
        return [
            ItemLocation(
                copy.copy(
                    ItemManager.Items[
                        itemLoc.item.type
                        if isinstance(itemLoc.item, SMItem) and itemLoc.item.type in ItemManager.Items
                        else 'ArchipelagoItem'
                    ]
                ),
                copy.copy(
                    locationsDict[itemLoc.name]
                    if itemLoc.game == self.game
                    else locationsDict[first_local_collected_loc.name]
                ),
                itemLoc.item.player,
                True
            )
            for itemLoc in spheres
            if itemLoc.item.player == self.player and (not progression_only or itemLoc.item.advancement)
        ]
"""

a_c = compile(a, "test", "single")
b_c = compile(b, "test", "single")

print(a_c == b_c)

[beauxq]

@lordlou

[lordlou]

All better, thank you!

[Exempt-Medic]

Compared the two formats with a parser.