TUNIC: Use push_precollected for start_with_sword #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
is: refactor/cleanup
silent-destroyer
approved these changes
Feb 23, 2024
ScipioWright
removed
the
waiting-on: world-maintainer
Berserker66
approved these changes
Feb 23, 2024
github-actions
bot
removed
the
waiting-on: peer-review
ScipioWright
added a commit
to ScipioWright/Archipelago-SW
that referenced
this pull request
Feb 27, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Uses push_precollected for the start_with_sword option instead of adding a sword to filler items. This makes it so that starting sword is considered in logic.
How was this tested?
Several gens, running unit tests, and checking to make sure the sword is still delivered in the client mod.
If this makes graphical changes, please attach screenshots.
N/A