Terraria: Add crate logic #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
benny-dreamly
approved these changes
Feb 19, 2024
| Dict[str, int], | ||
| ] | ||
| ): | ||
| def read_data() -> Tuple[ |
There was a problem hiding this comment.
Does this monster have to be built out of recursive tuples?
I'm scared
There was a problem hiding this comment.
Oh god I missed that now I’m shaking in my boots
There was a problem hiding this comment.
there's a reason for it. it accurately represents the data structure of the output data or something idk that's chatgpts word
There was a problem hiding this comment.
I think the outer tuple is fine, it gets split up on line 719, but yeah the rules type is messy. It's not relevant to this pr, though. It just got caught by my formatter. I'll move it to a class if I end up doing parser reworks
ScipioWright
added
the
is: enhancement
Exempt-Medic
approved these changes
Apr 5, 2024
Exempt-Medic
added
waiting-on: core-review
Berserker66
approved these changes
Apr 14, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Terraria fishing crate logic. I originally excluded it because it could be grindy, but I've found that it doesn't affect accessibility anyway, except for the Head in the Clouds achievement, whose logic I've changed based on whether grindy achievements are enabled.
How was this tested?
I generated a world and made sure checks still work, and then I generated a lot of worlds and checked if their spoilers match what I expect