Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: fix comment that did more harm than good #2826

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Core: fix comment that did more harm than good #2826

merged 1 commit into from
Feb 15, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

fix comment that did more harm than good

How was this tested?

no

If this makes graphical changes, please attach screenshots.

no

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 15, 2024
NewSoupVi
NewSoupVi approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bruh lmao

@ScipioWright ScipioWright added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. is: documentation Improvements or additions to documentation. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 15, 2024
hatkirby
hatkirby approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phew

@alwaysintreble
Copy link
Collaborator

This is already addressed in #2509.

black-sliver
black-sliver approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other PR still needs peer reviews.

@Berserker66 Berserker66 merged commit 9805bf9 into main Feb 15, 2024
24 checks passed
@Berserker66 Berserker66 deleted the core_fix_collect_comment branch February 15, 2024 22:34
@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 15, 2024
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@Berserker66 @Jouramie
Core: fix comment that did more harm than good (ArchipelagoMW#2826)
17c8d38
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
@Berserker66 @TheLX5
Core: fix comment that did more harm than good (ArchipelagoMW#2826)
a15bd05
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
@Berserker66 @TheLX5
Core: fix comment that did more harm than good (ArchipelagoMW#2826)
7987471
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Berserker66 @EmilyV99
Core: fix comment that did more harm than good (ArchipelagoMW#2826)
5d3f340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@hatkirby hatkirby hatkirby approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: documentation Improvements or additions to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Berserker66 @alwaysintreble @hatkirby @NewSoupVi @black-sliver @ScipioWright