-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ror2: Add progressive stages option #2813
Ror2: Add progressive stages option #2813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR has merge conflicts now, should probably handle that
…ogresssive # Conflicts: # worlds/ror2/rules.py
Thanks for letting me know. I don't really check these very often. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. I tested generating with
require_stages: false
,require_stages: true
andprogressive_stages: false
require_stages: true
andprogressive_stages: true
All generated fine and looking at the spoiler log they created the right items.
I tested each of those slots since the client 1.3.5 states it supports progressive stages. The first two worked properly. The third allowed me to continue to the next stage even without a Progressive Stage
item. However given that that would be a client bug and any fix wouldn't go in this repo, marking approve here
I am not getting this result in the client for progressive items. Did you perhaps accidentally have a progressive stage somehow? |
What is this fixing or adding?
This creates progressive items for the Stage items to help with confusion on which one is needed to progress to the next set of environments. This also adds an options to toggle stages off for the people that don't like the feature.
How was this tested?
Tested with looking at a few logs to make sure the items showed up and did a run with the new client to make sure they work correctly.
If this makes graphical changes, please attach screenshots.