Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ror2: Add progressive stages option #2813

Merged

Conversation

kindasneaki
Copy link
Collaborator

What is this fixing or adding?

This creates progressive items for the Stage items to help with confusion on which one is needed to progress to the next set of environments. This also adds an options to toggle stages off for the people that don't like the feature.

How was this tested?

Tested with looking at a few logs to make sure the items showed up and did a run with the new client to make sure they work correctly.

If this makes graphical changes, please attach screenshots.

@ScootyPuffJr1 ScootyPuffJr1 added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 11, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR has merge conflicts now, should probably handle that

@kindasneaki
Copy link
Collaborator Author

Looks like this PR has merge conflicts now, should probably handle that

Thanks for letting me know. I don't really check these very often.

Copy link
Collaborator

@remyjette remyjette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I tested generating with

  • require_stages: false,
  • require_stages: true and progressive_stages: false
  • require_stages: true and progressive_stages: true

All generated fine and looking at the spoiler log they created the right items.

I tested each of those slots since the client 1.3.5 states it supports progressive stages. The first two worked properly. The third allowed me to continue to the next stage even without a Progressive Stage item. However given that that would be a client bug and any fix wouldn't go in this repo, marking approve here

@kindasneaki
Copy link
Collaborator Author

Code changes look good to me. I tested generating with

  • require_stages: false,
  • require_stages: true and progressive_stages: false
  • require_stages: true and progressive_stages: true

All generated fine and looking at the spoiler log they created the right items.

I tested each of those slots since the client 1.3.5 states it supports progressive stages. The first two worked properly. The third allowed me to continue to the next stage even without a Progressive Stage item. However given that that would be a client bug and any fix wouldn't go in this repo, marking approve here

I am not getting this result in the client for progressive items. Did you perhaps accidentally have a progressive stage somehow?

@kindasneaki kindasneaki added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 23, 2024
@Berserker66 Berserker66 merged commit b007a42 into ArchipelagoMW:main Apr 9, 2024
15 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants