-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUNIC: Add an ER static connection, modify an nmg rule #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silent-destroyer
approved these changes
Feb 7, 2024
ScipioWright
added
the
is: enhancement
Issues requesting new features or pull requests implementing new features.
label
Feb 7, 2024
WillowDWisp
approved these changes
Feb 7, 2024
ScipioWright
changed the title
TUNIC: Add an ER static connection between Monastery Front and Quarry Back
TUNIC: Add an ER static connection, modify an nmg rule
Feb 8, 2024
ScipioWright
added
the
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
label
Feb 10, 2024
hatkirby
approved these changes
Feb 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not personally tested it, but the code looks correct to me.
ScipioWright
added
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
and removed
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
Feb 10, 2024
Berserker66
approved these changes
Feb 11, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…#2802) * Add laurels connection at monastery front * Removed an entrance rule to prevent people from being expected to softlock themselves
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
…#2802) * Add laurels connection at monastery front * Removed an entrance rule to prevent people from being expected to softlock themselves
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
…#2802) * Add laurels connection at monastery front * Removed an entrance rule to prevent people from being expected to softlock themselves
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
…#2802) * Add laurels connection at monastery front * Removed an entrance rule to prevent people from being expected to softlock themselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: enhancement
Issues requesting new features or pull requests implementing new features.
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds entrances between the Monastery Front region (the space in front of Monastery) and Quarry Back (the mountain stairs down to where the miasma starts), with a rule of having Laurels. This is just an easy connection to make since no combat is required, so you don't need a sword/wand for it.
This is for Entrance Rando only, since non-entrance rando does not split up Quarry to this degree.
Also removed an access rule from an entrance, as we changed our minds on having the player causing a potential soft lock.
How was this tested?
A few test generations.
If this makes graphical changes, please attach screenshots.
N/A